RE: [PATCH 4/x] arm: Add vst1_bf16 + vst1q_bf16 intrinsics

[Kyrylo Tkachov via Gcc-patches]

> -----Original Message-----
> From: Andrea Corallo <andrea.cora...@arm.com>
> Sent: 03 November 2020 11:01
> To: Kyrylo Tkachov <kyrylo.tkac...@arm.com>
> Cc: gcc-patches@gcc.gnu.org; Richard Earnshaw
> <richard.earns...@arm.com>; nd <n...@arm.com>
> Subject: Re: [PATCH 4/x] arm: Add vst1_bf16 + vst1q_bf16 intrinsics
> 
> Kyrylo Tkachov <kyrylo.tkac...@arm.com> writes:
> [...]
> > I see this patch also has the hunk:
> > diff --git a/gcc/config/arm/arm-builtins.c b/gcc/config/arm/arm-builtins.c
> > index 33e8015b140..6dc5df93216 100644
> > --- a/gcc/config/arm/arm-builtins.c
> > +++ b/gcc/config/arm/arm-builtins.c
> > @@ -946,6 +946,9 @@ typedef struct {
> >  #define VAR13(T, N, A, B, C, D, E, F, G, H, I, J, K, L, M) \
> >    VAR12 (T, N, A, B, C, D, E, F, G, H, I, J, K, L) \
> >    VAR1 (T, N, M)
> > +#define VAR14(T, N, A, B, C, D, E, F, G, H, I, J, K, L, M, O) \
> > +  VAR13 (T, N, A, B, C, D, E, F, G, H, I, J, K, L, M) \
> > +  VAR1 (T, N, O)
> >
> >  /* The builtin data can be found in arm_neon_builtins.def,
> arm_vfp_builtins.def
> >     and arm_acle_builtins.def.  The entries in arm_neon_builtins.def require
> >
> > That is a duplicate from a previous patch in the series and doesn't appear
> in the ChangeLog here.
> > I think it's in here by mistake?
> > Otherwise ok.
> > Thanks,
> > Kyrill
> 
> Hi Kyrill,
> 
> thanks for reviewing this.
> 
> Unless I'm wrong I see this hunk present in 3/x but not in 4/x.

Ah, you're right, I confused my views.
I need a better editor...
This is ok,
Kyrill

> 
>   Andrea