On Thu, Oct 29, 2020 at 12:50:10PM -0400, Michael Meissner wrote: > On Wed, Oct 28, 2020 at 06:27:42PM -0500, Segher Boessenkool wrote: > > On Thu, Oct 22, 2020 at 06:09:38PM -0400, Michael Meissner wrote: > > > This patch adds long double variants of the power10 __float128 built-in > > > functions. This is needed when long double uses IEEE 128-bit because > > > __float128 uses TFmode in this case instead of KFmode. If this patch is > > > not > > > applied, these built-in functions can't be used when long double is IEEE > > > 128-bit. > > > > But now they still cannot, you need new builtins, instead. > > > > TFmode is an implementation detail at this level (functions use types, > > not modes), so you do not need new builtins at all afaics? Just define > > the existing ones with TFmode as well (if that is the same as KFmode)? > > In order to add new overloaded built-ins, you have to add a new built-in with > a > new name.
I do not follow? Just delete the old non-overloaded one and add the overloaded one with that same old name at the same time. TF is a nasty name, it means a different thing externally (in the libgcc function names, say: always IFmode) and internally (it varies what it means). > Maybe when Bill finally reorganizes the built-in functions, we can do anyway > with having to create new named functions. But for now, in order to add them, > you need a name. Of course. And there already is a name :-) Segher
