> There are a few places in the ranger where we sanity check the types of
> the ranges. We were using types_compatible_p() but thats not really
> acccurate as gimple allows types which are useless_type_conversion_p()
> in only one direction, whereas types_compatible_p() requires casts in
> both directions to be useless_type_conversion_p().
>
> And, since its only a sanity check, ranges really only require that the
> precision and sign be the same, so its a faster check anyway.
>
> bootstrapped on x86_64-pc-linux-gnu, no regressions, pushed.
The Ada regression comes from this hunk:
diff --git a/gcc/gimple-range-gori.cc b/gcc/gimple-range-gori.cc
index c4bfc658319..983f4c97e87 100644
--- a/gcc/gimple-range-gori.cc
+++ b/gcc/gimple-range-gori.cc
@@ -552,7 +552,7 @@ is_gimple_logical_p (const gimple *gs)
case BIT_AND_EXPR:
case BIT_IOR_EXPR:
// Bitwise operations on single bits are logical too.
- if (types_compatible_p (TREE_TYPE (gimple_assign_rhs1 (gs)),
+ if (range_compatible_p (TREE_TYPE (gimple_assign_rhs1 (gs)),
boolean_type_node))
return true;
break;
which overlooks that boolean_type_node may have a precision not equal to 1
(it's 8 in Ada). See useless_type_conversion_p which has:
/* Preserve conversions to/from BOOLEAN_TYPE if types are not
of precision one. */
if (((TREE_CODE (inner_type) == BOOLEAN_TYPE)
!= (TREE_CODE (outer_type) == BOOLEAN_TYPE))
&& TYPE_PRECISION (outer_type) != 1)
return false
--
Eric Botcazou
