On Thu, Oct 22, 2020 at 04:52:10PM +0200, Tobias Burnus wrote: > + else > + { > + enum memmodel mo = MEMMODEL_LAST; > + switch (code->ext.omp_clauses->memorder) > + { > + case OMP_MEMORDER_ACQ_REL: mo = MEMMODEL_ACQ_REL; break; > + case OMP_MEMORDER_RELEASE: mo = MEMMODEL_RELEASE; break; > + case OMP_MEMORDER_ACQUIRE: mo = MEMMODEL_ACQUIRE; break; > + case OMP_MEMORDER_LAST: gcc_unreachable (); break;
I'd probably use default: gcc_unreachable (); break; here instead. Otherwise LGTM, thanks. Jakub