Hi! On Tue, Oct 20, 2020 at 12:10:59PM +0200, Olivier Hainque wrote: > This change introduces support for the most recent versions > of VxWorks on PowerPC targets, for both 32 and 64 bit thanks > to a bi-arch setup. > > The system compilers are essentially configured as Linux > toolchains with only a few specificities and we replicate > that model here.
> +powerpc*-wrs-vxworks7r*) > + > + # Wind River 7 post SR0600 is mostly like Linux so we setup > + # out config in a very similar fashion and adjust to a few > + # specificities. "our config"? > - analogous changes here too. */ > +/* The port comes in two very different flavors at this stage: > + > + - For 653 (AE) and regular versions prior to VxWorks 7, the port > + comes with its own set of definitions, matching a system compiler > + configured this way as well as the corresponding run-time > + environment. This is essentially an eabi system, so changes to > + eabi.h should usually be reflected here. > + > + - Starting with VxWorks 7 (post SR600), the system environment > + was made extremely similar to GNU/Linux and this toolchain is > + builtin on top of the corresponding header files. */ "built on top"? > +/**************************** > + * Common definitions first * > + ****************************/ We don't use such decorated comments in GCC. But it is your header file of course :-) I don't see anything wrong with the actual code itself, fwiw :-) Segher
