> On Wed, Oct 14, 2020 at 03:40:33PM +0200, Jan Hubicka wrote: > > this patch adds logic to handle POINTER_PLUS_EXPR in compute_parm_map > > that I originally did not since I tought that all such adjustments are > > done by ancestor function. > > > > Bootstrapped/regtested x86_64-linux, will commit it shortly. > > Honza > > > > gcc/ChangeLog: > > > > 2020-10-14 Jan Hubicka <hubi...@ucw.cz> > > > > * ipa-modref.c (compute_parm_map): Handle POINTER_PLUS_EXPR in > > PASSTHROUGH. > > > > gcc/testsuite/ChangeLog: > > > > 2020-10-14 Jan Hubicka <hubi...@ucw.cz> > > > > * gcc.dg/ipa/modref-1.c: New test. > > * gcc.dg/tree-ssa/modref-4.c: New test. > > Both of these tests FAIL everywhere: > FAIL: gcc.dg/ipa/modref-1.c (test for excess errors) > FAIL: gcc.dg/ipa/modref-1.c scan-ipa-dump modref "param offset: 1" > FAIL: gcc.dg/ipa/modref-1.c scan-ipa-dump modref "param offset: 2" > FAIL: gcc.dg/tree-ssa/modref-4.c (test for excess errors) > FAIL: gcc.dg/tree-ssa/modref-4.c scan-tree-dump modref1 "param offset: 1" > UNRESOLVED: gcc.dg/tree-ssa/modref-4.c scan-tree-dump modref2 "param offset: > 2" > UNRESOLVED: gcc.dg/tree-ssa/modref-4.c scan-tree-dump modref2 "return 0" > > I've tried to fix most of things, but > FAIL: gcc.dg/tree-ssa/modref-4.c scan-tree-dump modref1 "return 0" > remains (it isn't even optimized in optimized dump). > > Committed to trunk as obvious anyway, but please tweak the modref-4.c > test according to what you meant. > > 2020-10-15 Jakub Jelinek <ja...@redhat.com> > > * gcc.dg/ipa/modref-1.c: Remove space between param offset: and number > in scan-ipa-dump. > (b): Declare return type to void. > (main): Declare return type to int. Change c to array of 3 chars. > * gcc.dg/tree-ssa/modref-4.c: Remove space between param offset: and > number in scan-ipa-dump. Use modref1 instead of modref2. > (b): Declare return type to void. > (main): Declare return type to int. Change c to array of 3 chars. Sorry for that - I had fixed versions of the testcases but must have mixed the up. I will look at the reutrn 0 case.
Honza