On 14/10/2020 9:20 am, Jakub Jelinek wrote:
On Tue, Oct 13, 2020 at 07:05:10PM +0100, Kwok Cheung Yeung wrote:
+* omp_get_supported_active_levels:: Maxiumum number of active levels supported
Sorry for not catching it during review, but there is a typo above. Fixed
with patch below, committed to trunk.
Thanks.
+@node omp_get_supported_active_levels
+@section @code{omp_get_supported_active_levels} -- Maximum number of active
regions supported
I also wonder about the different wording between the above two places,
don't you want the same wording as earlier here?
Yes, they should be the same... I think I was playing around with wording (since
the description for omp_get_max_active_levels is 'Maximum number of active
regions' - different by one extra word!), and forgot to make them consistent.
Maybe we should change the description of omp_get_max_active_levels to 'Current
maximum number of active regions', to make it more obvious that it can be
changed? 'omp_get_supported_active_levels' can then be 'Maximum number of active
regions supported'.
Okay to apply this patch?
Kwok
commit 3f6f8808f74598e274bfb8245c08a5428ee1b3fd
Author: Kwok Cheung Yeung <k...@codesourcery.com>
Date: Thu Oct 15 02:32:09 2020 -0700
Amend documentation for omp_get_max_active_levels and
omp_get_supported_active_levels
2020-10-15 Kwok Cheung Yeung <k...@codesourcery.com>
libgomp/
* libgomp.texi (omp_get_max_active_levels): Modify description.
(omp_get_supported_active_levels): Make descriptions consistent.
diff --git a/libgomp/libgomp.texi b/libgomp/libgomp.texi
index 4a5e56f..7c6d5fd 100644
--- a/libgomp/libgomp.texi
+++ b/libgomp/libgomp.texi
@@ -167,7 +167,7 @@ linkage, and do not throw exceptions.
* omp_get_default_device:: Get the default device for target regions
* omp_get_dynamic:: Dynamic teams setting
* omp_get_level:: Number of parallel regions
-* omp_get_max_active_levels:: Maximum number of active regions
+* omp_get_max_active_levels:: Current maximum number of active regions
* omp_get_max_task_priority:: Maximum task priority value that can be set
* omp_get_max_threads:: Maximum number of threads of parallel region
* omp_get_nested:: Nested parallel regions
@@ -177,7 +177,7 @@ linkage, and do not throw exceptions.
* omp_get_num_threads:: Size of the active team
* omp_get_proc_bind:: Whether theads may be moved between CPUs
* omp_get_schedule:: Obtain the runtime scheduling method
-* omp_get_supported_active_levels:: Maximum number of active levels supported
+* omp_get_supported_active_levels:: Maximum number of active regions supported
* omp_get_team_num:: Get team number
* omp_get_team_size:: Number of threads in a team
* omp_get_thread_limit:: Maximum number of threads
@@ -380,7 +380,7 @@ which enclose the calling call.
@node omp_get_max_active_levels
-@section @code{omp_get_max_active_levels} -- Maximum number of active regions
+@section @code{omp_get_max_active_levels} -- Current maximum number of active
regions
@table @asis
@item @emph{Description}:
This function obtains the maximum allowed number of nested, active parallel
regions.
