On 10/7/20 11:19 AM, Aldy Hernandez wrote:
On 10/7/20 8:10 AM, Richard Biener wrote:
> On Tue, Oct 6, 2020 at 7:06 PM Andrew MacLeod via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>>
>> I have now checked in the hybrid EVRP pass.
>>
>> We have resolved all the issue we are aware of with a full Fedora
build,
>> but if any more issues arise, please let us know. (And Im sure you
will :-)
>>
>> I made some minor tweaks. the option to the new -fevrp-mode flag
are now:
>>
>> legacy : classic EVRP mode
>> ranger : Ranger only mode
>> *legacy-first : Query ranges with EVRP first, and if that
fails try
>> the ranger*
>> ranger-first : Query the ranger first, then evrp
>> ranger-trace : Ranger-only mode plus Show range tracing info in
the dump
>> ranger-debug : Ranger-only mode, and also include all cache
debugging info
>> trace : Hybrid mode with range tracing info
>> debug : Hybrid mode with cache debugging as well as
tracing
>>
>> The default is still *legacy-first*.
>
> We'll have to keep -fevrp-mode forever so can you instead make it a
--param
> since I hope it is transitional only? It certainly shouldn't be a
> user-visible flag, should it?
Sounds reasonable.
Attached is a patch to do so. It basically moves the code from
common.opt to params.opt. I also removed the undocumented modifier,
as all --params are supposed to be for internal use only.
OK?
* common.opt (-fevrp-mode): Rename and move...
* params.opt (--param=evrp-mode): ...here.
* gimple-range.h (DEBUG_RANGE_CACHE): Use param_evrp_mode instead
of flag_evrp_mode.
* gimple-ssa-evrp.c (rvrp_folder): Same.
(hybrid_folder): Same.
(execute_early_vrp): Same.
OK. thanks.
Andrew
