> On Sun, 2020-09-20 at 19:30 +0200, Jan Hubicka wrote: > > > > > [...] > > > > Should new C++ source files have a .cc suffix, rather than .c? > > > > > > [...] > > > > > > > + $(srcdir)/ipa-modref.h $(srcdir)/ipa-modref.c \ > > > > > > ...which would affect this ^^^^^^^^^^^^^ > > > > I was wondering about that and decided to stay with .c since it is > > what > > other ipa passes use. I can rename the files. > > Given that they're in the source tree now, maybe better to wait until > some mass renaming in the future?
At the same time, I am only having patches against it, and I have no problem update the name. > > > We have some sources with > > .c extension and others with .cc while they are now all C++. Is there > > some plan to clean it up? > > I think we've been avoiding it, partly out of a concern of making > backports harder, and also because someone has to do the work. > > That said, it's yet another unfinished transition, and is technical > debt for the project. It's confusing to newcomers. > > It's been bugging me for a while, so I might take a look at doing it in > this cycle. Agreed. It would be nice to do the mass rename and at the same time make a sane directory structure so newcomers can locate optimization passes and other components. David Cepelik was my student so he may have some feedback about what he found hard. I think main stoppers was the garbage collector (since he decided to do the template for modref tree) and the flat includes that breaks if you do not do them in right order and resolve all dependencies. Honza > > Dave >
