Thanks for your review. It seems like the format issue was introduced by my email client when hitting reply. Sorry for that! The original patch is formatted correctly, as I used git send-email: https://gcc.gnu.org/pipermail/gcc-patches/2020-August/552079.html
Could you double-check and push the patch for me? This is the first time I contribute to gcc and I therefore don't have write access. Regards, Felix -----Original Message----- From: Joseph Myers <jos...@codesourcery.com> Sent: Montag, 7. September 2020 21:45 To: Willgerodt, Felix <felix.willger...@intel.com> Cc: gcc-patches@gcc.gnu.org Subject: Re: [PING] floatformat.h: Add bfloat16 support. On Mon, 7 Sep 2020, Willgerodt, Felix via Gcc-patches wrote: > @@ -133,6 +133,9 @@ extern const struct floatformat > floatformat_ia64_quad_little; > /* IBM long double (double+double). */ extern const struct > floatformat floatformat_ibm_long_double_big; extern const struct > floatformat floatformat_ibm_long_double_little; > +/* bfloat16. */ > +extern const struct floatformat floatformat_bfloat16_big; extern > +const struct floatformat floatformat_bfloat16_little; There seems to be something odd about the diff formatting here. I'd expect each declaration to be on its own line, not "extern const" at the end of a line and the rest of a declaration on the next line. OK with that fixed. -- Joseph S. Myers mailto:jos...@codesourcery.com Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Gary Kershaw Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928
