On Tue, Aug 11, 2020 at 01:30:36PM -0500, Segher Boessenkool wrote: > Either always running or what this patch does will work. But please add > comments what the test case wants to test,
That's already in the testcase. /* Test local calls between pcrel and non-pcrel code. The comment goes on to say Despite the cpu=power10 option, the code generated here should just be plain powerpc64, even the necessary linker stubs. */ which was the justification for using "dg-do run" unqualified in the current testcase. > and for the tricky bits. There aren't any. And other tests use multiple dg-do lines, eg. gcc/testsuite/g++.dg/ext/altivec-3.C /* { dg-do run { target { powerpc*-*-* && vmx_hw } } } */ /* { dg-do compile { target { powerpc*-*-* && { ! vmx_hw } } } } */ Committed 2ba0674c657, and apologies for missing the power10_ok first time around on this test. -- Alan Modra Australia Development Lab, IBM