On Wed, 2012-01-04 at 10:53 -0500, Patrick Marlier wrote: > On 01/02/2012 01:10 PM, Torvald Riegel wrote: > > This was motivated by the miscompilation of one of the STAMP > > applications (Genome), where a stack slot was used as temp storage for a > > CPU register but not restored when the transaction got aborted and > > restarted (then, after restart, the program crashed because it used > > inconsistent data). With the attached patch and in this particular > > example, the stack slots that are written to in the transaction do not > > get read during the transaction. (-fno-caller-saves was not a > > sufficient solution, BTW.) > > Are you sure this not due to the missing of tm-logging? We xfail until > now for the testsuite but this should be addressed. (Note that I tested > genome months ago and it was working correctly.)
I think so. This could be fixed with logging, but I don't think that's the right way to handle this. Perhaps its related though (unless the PR's you cited are indeed just missed optimizations). Patrick, I forwarded you the details of the issue...
