Hi Kwok!
On 2020-07-22T13:31:30+0100, Kwok Cheung Yeung <k...@codesourcery.com> wrote:
> This test currently fails because some expected 'optimized: assigned OpenACC
> seq
> loop parallelism' messages are not being printed by the compiler. This is
> because the '.auto. conflicts with other OpenACC loop specifiers'
> errors
(... which is actually not correct, but it's what we've currently got...)
> are
> generated in the earlier omp-low pass, whereas the messages are emitted in the
> later oacc_loop_designation pass. The errors in the earlier pass means that
> the
> later pass is never executed.
>
> In 'Update expected messages, errors and warnings for "kernels" tests' (commit
> 081a01963ca8db7ddaaf5871d281321454fd3246)
(... which actually should've been part of the respective code changes commits?)
> dg-messages for 'optimized: assigned
> OpenACC .* parallelism' messages are removed from
> note-parallelism-1-kernels-loop-auto.c,
> note-parallelism-combined-kernels-loop-auto.c and
> note-parallelism-kernels-loop-auto.c. I suppose the remaining entries in
> note-parallelism-combined-kernels-loop-auto.c were just missed by accident?
>
> This patch removes the dg-messages for the no-longer occurring messages.
>
> Okay for OG10?
That seems reasonable, yes, thanks.
> From 59c6bc996000fb69ee8cf2cee3ec2e279524e66f Mon Sep 17 00:00:00 2001
> From: Kwok Cheung Yeung <k...@codesourcery.com>
> Date: Thu, 18 Jun 2020 13:32:40 -0700
> Subject: [PATCH 1/6] Fix failures in
> c-c++-common/goacc/note-parallelism-combined-kernels-loop-auto.c testcase
>
> 2020-07-21 Kwok Cheung Yeung <k...@codesourcery.com>
>
> gcc/testsuite/
> * c-c++-common/goacc/note-parallelism-combined-kernels-loop-auto.c
> (main): Remove obsolete expected messages.
Please amend the commit log to state that this should've been part of
'Update expected messages, errors and warnings for "kernels" tests'
(og10 commit 081a01963ca8db7ddaaf5871d281321454fd3246).
Grüße
Thomas
> .../goacc/note-parallelism-combined-kernels-loop-auto.c | 16
> ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git
> a/gcc/testsuite/c-c++-common/goacc/note-parallelism-combined-kernels-loop-auto.c
>
> b/gcc/testsuite/c-c++-common/goacc/note-parallelism-combined-kernels-loop-auto.c
> index 806ccc7..b1ef3c0 100644
> ---
> a/gcc/testsuite/c-c++-common/goacc/note-parallelism-combined-kernels-loop-auto.c
> +++
> b/gcc/testsuite/c-c++-common/goacc/note-parallelism-combined-kernels-loop-auto.c
> @@ -11,7 +11,7 @@ main ()
> {
> int x, y, z;
>
> -#pragma acc kernels loop /* { dg-message "optimized: assigned OpenACC seq
> loop parallelism" } */
> +#pragma acc kernels loop
> /* { dg-message "optimized: forwarded loop nest in OpenACC .kernels.
> construct to .parloops. for analysis" "" { target *-*-* } .-1 } */
> for (x = 0; x < 10; x++)
> ;
> @@ -60,19 +60,19 @@ main ()
> for (z = 0; z < 10; z++)
> ;
>
> -#pragma acc kernels loop auto /* { dg-message "optimized: assigned OpenACC
> seq loop parallelism" } */
> +#pragma acc kernels loop auto
> /* { dg-message "optimized: forwarded loop nest in OpenACC .kernels.
> construct to .parloops. for analysis" "" { target *-*-* } .-1 } */
> for (x = 0; x < 10; x++)
> ;
>
> -#pragma acc kernels loop auto /* { dg-message "optimized: assigned OpenACC
> seq loop parallelism" } */
> +#pragma acc kernels loop auto
> /* { dg-message "optimized: forwarded loop nest in OpenACC .kernels.
> construct to .parloops. for analysis" "" { target *-*-* } .-1 } */
> for (x = 0; x < 10; x++)
> #pragma acc loop auto
> for (y = 0; y < 10; y++)
> ;
>
> -#pragma acc kernels loop auto /* { dg-message "optimized: assigned OpenACC
> seq loop parallelism" } */
> +#pragma acc kernels loop auto
> /* { dg-message "optimized: forwarded loop nest in OpenACC .kernels.
> construct to .parloops. for analysis" "" { target *-*-* } .-1 } */
> for (x = 0; x < 10; x++)
> #pragma acc loop auto
> @@ -81,7 +81,7 @@ main ()
> for (z = 0; z < 10; z++)
> ;
>
> -#pragma acc kernels loop /* { dg-message "optimized: assigned OpenACC seq
> loop parallelism" } */
> +#pragma acc kernels loop
> /* { dg-message "optimized: forwarded loop nest in OpenACC .kernels.
> construct to .parloops. for analysis" "" { target *-*-* } .-1 } */
> for (x = 0; x < 10; x++)
> #pragma acc loop auto
> @@ -90,7 +90,7 @@ main ()
> for (z = 0; z < 10; z++)
> ;
>
> -#pragma acc kernels loop auto /* { dg-message "optimized: assigned OpenACC
> seq loop parallelism" } */
> +#pragma acc kernels loop auto
> /* { dg-message "optimized: forwarded loop nest in OpenACC .kernels.
> construct to .parloops. for analysis" "" { target *-*-* } .-1 } */
> for (x = 0; x < 10; x++)
> #pragma acc loop
> @@ -99,7 +99,7 @@ main ()
> for (z = 0; z < 10; z++)
> ;
>
> -#pragma acc kernels loop auto /* { dg-message "optimized: assigned OpenACC
> seq loop parallelism" } */
> +#pragma acc kernels loop auto
> /* { dg-message "optimized: forwarded loop nest in OpenACC .kernels.
> construct to .parloops. for analysis" "" { target *-*-* } .-1 } */
> for (x = 0; x < 10; x++)
> #pragma acc loop auto
> @@ -108,7 +108,7 @@ main ()
> for (z = 0; z < 10; z++)
> ;
>
> -#pragma acc kernels loop /* { dg-message "optimized: assigned OpenACC seq
> loop parallelism" } */
> +#pragma acc kernels loop
> /* { dg-message "optimized: forwarded loop nest in OpenACC .kernels.
> construct to .parloops. for analysis" "" { target *-*-* } .-1 } */
> for (x = 0; x < 10; x++)
> #pragma acc loop auto
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander
Walter
