Andrea Corallo <andrea.cora...@arm.com> writes:
> Przemyslaw Wirkus <przemyslaw.wir...@arm.com> writes:
>
>> diff --git a/gcc/testsuite/gcc.target/aarch64/ldp_vec_v2sf.c 
>> b/gcc/testsuite/gcc.target/aarch64/ldp_vec_v2sf.c
>> new file mode 100644
>> index 
>> 0000000000000000000000000000000000000000..fbdae1c6cff1aef40db644361381ce511f0be64a
>> --- /dev/null
>> +++ b/gcc/testsuite/gcc.target/aarch64/ldp_vec_v2sf.c
>> @@ -0,0 +1,14 @@
>> +/* { dg-do compile } */
>> +/* { dg-options "-O2" } */
>> +
>> +typedef float __attribute__((vector_size(8))) vec;
>> +
>> +vec
>> +load_long(vec *v) {
>
> Hi Przemyslaw,
>
> I think here we should have a space before '(' and a new line before
> '{'.
>
> Same applies for the other testcases.

Yeah, that's certainly true for code in the compiler itself.  Tests
kind-of get a pass stylewise though.  It would be bad if everything in
the testsuite used GNU style, since then we'd never test anything else. ;-)

So the patch is OK as-is or with the above change.

Przemek, if you don't have commit access already, please follow
the steps on https://gcc.gnu.org/gitwrite.html (happy to sponsor).

Thanks,
Richard

Reply via email to