Le 2020-06-27 13:34, Thomas Koenig a écrit :
Hi Dominieque,
While investigating pr95538, I see several module files that were not
cleaned.
Several were cleaned by a patch I had in my working directory.
However new ones were not cleaned (e.g., gfortran.dg/pr95091.f90) due
to continuation lines.
This is now fixed with the attached patch (patch-mod).
Thanks for working on this.
My problem is that I my dejagnu-fu is almost nonexistent, so I could,
in theory, review and commit this, but I do not really understand what
you did. So, maybe if somebody more knowledgable about this could
this could comment on
Hi Thomas,
Thanks for having a look. The patch is for two Tcl procedures, thus have
very little to do with dejagnu.
It is basically related to Tcl and regular expressions.
If you want to refresh your Tcl you may want to look, e.g.,
http://www.tcl-lang.org/man/tcl8.6/TclCmd/contents.htm
The first part of the patch for the proc 'list-module-names-1'
extends the existing procedure to handle additional-sources
and aux-modules. In order to avoid too long lines, I have
split the initial pattern 'pat' in four pieces.
The second part of the patch is for the proc 'f90grep' (borrowed from
dejagnu
and renamed from igrep, as in grep -i) in order to handle (sun)?module
with
free-form continuation lines.
I am fully aware that some user may find a way to break the proposed
logic,
however it does not introduce new Tcl error, nor new failure in the test
suite,
and it works as expected for the present test suite.
I can take the responsibility of the patch if there is nobody to review
it
and I'll do my best if a new test introduce a regression.
Cheers,
Dominique
PS. Handling continuations in fixed-form is certainly doable, but more
complicated
since you need to keep track of the previous line and it is not needed
at the moment.
https://gcc.gnu.org/pipermail/fortran/2020-June/054533.html ?
Best regards
Thomas
