Hi Thomas,

> OK, but don't forget the test case :-)

the testcase was in the patch.  I just do not add it to the commit message,
because that's now done automagically by the new scripts.

> Because the if takes up quite a few lines, it is also an option to
> write something like
>
> gfc_error ("Symbol %qs at %L cannot have a type",
>          sym->ns->proc_name->name
>            ? sym->ns->proc_name->name : sym->name , where);
>
> simply to have more code on the screen at one time.  If you happen
> to be inclined that way, that variant is also OK.

Done.  It actually came to my mind after submitting the patch.

I'm more a Fortran programmer than C, and the ternary MERGE would
be forbidden in that situation.

> Thanks for the patch!

And thanks for the comments!

Harald

Reply via email to