On Wed, Jun 24, 2020 at 3:37 PM Uros Bizjak <[email protected]> wrote:
>
> On Wed, Jun 24, 2020 at 3:06 PM H.J. Lu <[email protected]> wrote:
> >
> > On Wed, Jun 24, 2020 at 02:43:43PM +0200, Uros Bizjak wrote:
> > > >
> > > > Here is the updated patch for x86 backend and libgcc. driver-i386.c
> > > > is unchanged.
> > >
> > > Thanks. We should change driver-i386.c very carefully and in an
> > > independent way from this patch. It is a complex and interwoven web of
> > > name, model and features check. I propose that we first convert
> > > various has_xxx checks to a new interface, in as trivial way as
> > > possible.
> > >
> >
> > Here is the patch to share isa_names_table and use cpuinfo.h to check
> > ISAs as well as detect newer Intel/AMD processors.
> >
> > OK for master?
>
> No. Don't use get_intel_cpu and get_amd_cpu in driver-i386.c.
+ cpu = get_amd_cpu (&cpu_model, &cpu_model2, cpu_features2);
+ if (cpu == NULL)
+ {
+ if (name == signature_NSC_ebx)
+ processor = PROCESSOR_GEODE;
+ else if (has_feature (FEATURE_SSE2)
Here is where your patch fails. AMD part has early bypass for
signature_NSC_ebx, so it is detected as NSC processor regardless of
what is detected by generic code.
Uros.
