The correct subject should be more like c++: Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic [PR95672]
See git log --oneline for examples. On Tue, Jun 23, 2020 at 03:11:44PM -0400, Nicholas Krause via Gcc-patches wrote: > From: Nicholas Krause <xerofo...@gmail.com> > > This fixs the PR95672 by adding the missing TYPE_PACK_EXPANSION case in "fixes" > cxx_incomplete_type_diagnostic in order to avoid ICES on diagnosing > incomplete template pack expansion cases. In v2, add the missing required > test case for all new patches. v3 Fixes both the test case to compile in > C++11 mode and the message to print out only the type. v4 fixes the testcase > to only target C++11. v5 and v6 fix the test case properly. v7 fixes running ...running what? > gcc/cp/ChangeLog: > > * typeck2.c (cxx_incomplete_type_diagnostic):Add missing > TYPE_EXPANSION_PACK check for diagnosicing incomplete > types in cxx_incomplete_type_diagnostic. This still won't pass git gcc-verify and we've already told you twice that the correct term is "diagnosing". Missing space after ':'. The ChangeLog entry also misses "PR c++/95672". You never mentioned how the patch was tested. Marek
