On Jun 19, 2020, Tobias Burnus <[email protected]> wrote:
> Done; nvptx compiled but for AMDGCN I got a compile error:
> in one function 'argv_obstack' was lacking a 'cc_' prefix ('cc_argv_obstack'),
> see attached patch (vs. mainline, not vs. either of your patches).
Ah, I see, cut&pasto, different obstacks. Thanks for fixing it.
> And there is an (unfixed) warning:
> config/gcn/mkoffload.c:535:9: warning: unused variable 'dumpbase'
Thanks, I've removed that.
> I additionally did run the test case manually → files.log for the
> produced files.
This is with -save-temps, right? I've arranged to drop the
no-longer-necessary -save-temps from the test runs, but you didn't get
to experience it because of:
> Unfortunately, running the testsuite fails now with a tcl error:
> : error executing dg-final: unknown or ambiguous subcommand "set":
Interesting, in my test run (native only) I didn't trigger that problem.
+++ b/gcc/testsuite/lib/scanoffload.exp
+ if [info set offload_target] {
The 'set' above should be 'exists'.
--
Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo/
Free Software Evangelist Stallman was right, but he's left :(
GNU Toolchain Engineer Live long and free, and prosper ethically
