Hi Jim: Thanks for your review, committed with ASM_SPECS clean up.
> This has the side effect that we are now passing -march twice to cc1 and as, > but that should be harmless as the last one wins. Yeah, I tried to find a way to remove the duplication but have not found a good solution yet. On Sun, Jun 21, 2020 at 5:37 AM Jim Wilson <j...@sifive.com> wrote: > > On Fri, Jun 19, 2020 at 2:53 AM Kito Cheng <kito.ch...@sifive.com> wrote: > > * config/riscv/riscv.h (DRIVER_SELF_SPECS): New. > > This looks good to me. This has the side effect that we are now > passing -march twice to cc1 and as, but that should be harmless as the > last one wins. I think this makes the riscv_expand_arch call in > ASM_SPECS redundant, but it isn't really hurting anything if we end up > with extra unnecessary calls to riscv_expand_arch so that is an > optional possible cleanup. > > Jim
