It turned out that this patch fails with LTO and partitions,
causing fails at runtime such as
libgomp: Duplicate node
via libgomp/splay-tree.c's splay_tree_insert.
In the test case, the problem occurred for functions - namely
main._omp_fn.* on the host.
If the code is run in LTO context, the filtering-out should
have already happen via the stream-out/stream-in and hence no
additional check is needed for omp_finish_file.
OK?
Tobias
PS: The streaming-in is done via:
input_offload_tables (/* do_force_output = */ !flag_ltrans);
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander
Walter
openmp: ensure variables in offload table are streamed out (PRs 94848 + 95551)
gcc/ChangeLog:
* omp-offload.c (add_decls_addresses_to_decl_constructor,
omp_finish_file): With in_lto_p, stream out all offload-table
items even if the symtab_node does not exist.
diff --git a/gcc/omp-offload.c b/gcc/omp-offload.c
index 4e44cfc9d0a..32c2485abd4 100644
--- a/gcc/omp-offload.c
+++ b/gcc/omp-offload.c
@@ -126,7 +126,7 @@ add_decls_addresses_to_decl_constructor (vec<tree, va_gc> *v_decls,
&& lookup_attribute ("omp declare target link", DECL_ATTRIBUTES (it));
/* See also omp_finish_file and output_offload_tables in lto-cgraph.c. */
- if (!symtab_node::get (it))
+ if (!in_lto_p && !symtab_node::get (it))
continue;
tree size = NULL_TREE;
@@ -382,14 +382,14 @@ omp_finish_file (void)
tree it = (*offload_funcs)[i];
/* See also add_decls_addresses_to_decl_constructor
and output_offload_tables in lto-cgraph.c. */
- if (!symtab_node::get (it))
+ if (!in_lto_p && !symtab_node::get (it))
continue;
targetm.record_offload_symbol (it);
}
for (unsigned i = 0; i < num_vars; i++)
{
tree it = (*offload_vars)[i];
- if (!symtab_node::get (it))
+ if (!in_lto_p && !symtab_node::get (it))
continue;
#ifdef ACCEL_COMPILER
if (DECL_HAS_VALUE_EXPR_P (it)
