Hello, Anthony, H-P, On May 27, 2020, Anthony Green <gr...@moxielogic.com> wrote:
> Hans-Peter Nilsson via Gcc-patches <gcc-patches@gcc.gnu.org> writes: >> And here's an improper bug report. >> >> One of the commits between cfdff3eeb90..5c8344e7289 caused every >> single *linked* test to fail for cris-elf, like: > I can confirm that the moxie-elf test cases don't link either. I believe the problem reported by Hans-Peter was fixed in the follow up I put in the other day, but I happened to stumble across more recent test results you've posted, and it looks like you're still running into problems. > It looks like setting ldscript in the board description file doesn't > work. In my case that means "-Tsim.ld" isn't being passed through and > we can't link anymore. Here's moxie-sim.exp: > https://github.com/moxielogic/moxie-test-gcc/blob/7c707e187f101922e3ef7f6e23dbbd1890f9e8dd/moxie-sim.exp#L42 Looking more closely, I realized I used ldscripts instead of ldscript in the recent changes. That would explain at least the outputs.exp failures. Would you please let me know whether the patch below brings you back to the state before the revamp patch went in? Failing that, could you possibly share a gcc.log with me? Thanks in advance, diff --git a/gcc/testsuite/gcc.misc-tests/outputs.exp b/gcc/testsuite/gcc.misc-tests/outputs.exp index c3c6c2d..06a32db 100644 --- a/gcc/testsuite/gcc.misc-tests/outputs.exp +++ b/gcc/testsuite/gcc.misc-tests/outputs.exp @@ -48,7 +48,7 @@ set skip_lto ![check_effective_target_lto] # We do not compile to an executable, because that requires naming an output. set link_options "" set dest [target_info name] -foreach i { ldflags libs ldscripts } { +foreach i { ldflags libs ldscript } { if {[board_info $dest exists $i]} { set skip "" foreach opt [split [board_info $dest $i]] { diff --git a/gcc/testsuite/lib/gcc-defs.exp b/gcc/testsuite/lib/gcc-defs.exp index d591cb3..87eeb7d 100644 --- a/gcc/testsuite/lib/gcc-defs.exp +++ b/gcc/testsuite/lib/gcc-defs.exp @@ -287,7 +287,7 @@ proc dg-additional-files { args } { set gcc_adjusted_linker_flags 0 -# Add -Wl, before any file names in ldflags, libs, and ldscripts, so +# Add -Wl, before any file names in ldflags, libs, and ldscript, so # that default object files or libraries do not change the names of # gcc auxiliary outputs. @@ -300,7 +300,7 @@ proc gcc_adjust_linker_flags {} { if {![is_remote host]} { set dest [target_info name] - foreach i { ldflags libs ldscripts } { + foreach i { ldflags libs ldscript } { if {[board_info $dest exists $i]} { set opts [board_info $dest $i] set nopts {} -- Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo/ Free Software Evangelist Stallman was right, but he's left :( GNU Toolchain Engineer Live long and free, and prosper ethically
