>>>>> "David" == David Malcolm <dmalc...@redhat.com> writes:

>> I tested this using the self-tests.  A new self-test is also
>> included.

> Did the full DejaGnu testsuite get run?  There are a lot of tests in it
> that make use of this code.

I didn't try it, but I can.

> The patch should probably update the leading comment to
> get_edit_distance.

Will do.

>> test_get_edit_distance_both_ways ("foo", "FOO", 3);
[...]

> If I'm reading things correctly, the patch here updates the existing
> tests to apply the BASE_COST scale factor, but I don't think it adds
> any direct checks of the cost of case-conversion.  It would be good to
> add those.

It isn't obvious but the foo/FOO test did change.

Tom

Reply via email to