Hi, Doug,
Sorry about the delay, I'd somehow missed your email.
On May 20, 2020, Douglas B Rupp <r...@adacore.com> wrote:
> 2020-05-20 Douglas B Rupp <r...@adacore.com>
> libstdc++v3/
> * crossconfig.m4 (GLIBCXX_CHECK_MATH_DECL): More reject macros.
> * configure: Rebuild.
The change is ok, but the ChangeLog entry isn't.
You're not modifying the m4 macro associated with the name between
parentheses, but rather a use thereof. The entry of mine that you based
it on actually introduced the m4 macro (and its use), so the
parenthesized ChangeLog construct made sense there. Without a change to
that macro, as in your patch, it doesn't seem correct.
I also realized my own ChangeLog entry was misleading and unclear:
macros could refer to both the preprocessor macros defined by the
checks, that are then used to reject replacement definitions, or to the
standard math functions themselves, that might be implemented by macros
in C, and we can't allow such macro implementations to pollute all C++
namespaces.
Patch is ok with the following ChangeLog entry:
* crossconfig.m4 <*-vxworks>: Check for more math decls.
* configure: Rebuild.
Thanks!
--
Alexandre Oliva, freedom fighter he/him https://FSFLA.org/blogs/lxo/
Free Software Evangelist Stallman was right, but he's left :(
GNU Toolchain Engineer Live long and free, and prosper ethically
