On Thu, 21 May 2020, Alexandre Oliva wrote: > On May 19, 2020, Richard Biener <rguent...@suse.de> wrote: > > > On Tue, 19 May 2020, Alexandre Oliva wrote: > >> I've refreshed the patch, approved back on Jan 22 for gcc-11, in > >> refs/users/aoliva/heads/aux-dump-revamp, and committed 3 other related > >> patches on top of it, that I hope to get approved for folding and joint > >> installation: > > > Thanks again for doing this. May I also suggest to prepare a short > > entry for gcc-11/changes.html with these things (like "Output of > > auxiliary files changed. See https://gcc.gnu.org/ml/gcc-patches/... > > for details")? > > How about, under Caveats: > > * Naming and location of auxiliary and dump output files changed. If > you compile multiple input files in a single command, if you enable Link > Time Optimization, or if you use -dumpbase, -dumpdir, -save-temps=*, and > you expect any file other than the primary output file(s) to be created > as a side effect, watch out for improvements and a few surprises. See > https://gcc.gnu.org/ml/...
Looks good to me. > > Before I can check it all in, I'm still missing a review of: > > https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546015.html > > Did you by any chance miss it, or choose not to review it? I looked at it shortly but decided somebody else may have more knowledge there - I'd simply trust you'd done things correctly... So unless anybody comes up to review and ack it consider it approved by me after the weekend ;) Thanks, Richard. > Any takers? > > I've just realized I failed to mention I'd regstrapped the patchset on > x86_64-linux-gnu, and got successful cross builds and regression test > results for arm-elf, aarch64-elf, aarch64-vx7r2, and x86_64-windows. > > -- Richard Biener <rguent...@suse.de> SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)
