On 5/19/20 11:45 AM, Frederik Harwath wrote:
Hi,
the new contrib/gcc-changelog/git_check_commit.py script
(which, by the way, is very useful!) does not handle "Reviewed-by" and
"Reviewed-on" lines yet and hence it expects those lines to be indented
by a tab although those lines are usually not indented. The script
already knows about "Co-Authored-By" lines and I have extended it to
handle the "Reviewed-{by,on}" lines in a similar way. The information
from those lines is not processed further since the review information
apparantly does not get included in the ChangeLogs.
Thank you Frederick for the patch.
Looking at what I grepped:
https://github.com/marxin/gcc-changelog/issues/1#issuecomment-621910248
Can you also add 'Signed-off-by'? And please create a list with these
exceptions at the beginning of the script.
Fine with that.
Martin
Ok to commit the patch?
Best regards,
Frederik
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander
Walter
