On Mon, 2020-05-11 at 22:48 +0100, Andrew Burgess wrote:
> This commit is for the benefit of GDB, but as the binutils-gdb
> repository shares the contrib/ directory with gcc, this commit must
> first be applied to gcc then copied back to binutils-gdb.
>
> This commit extends the two scripts contrib/dg-extract-results.{py,sh}
> to handle some new, GDB specific test result types. These test
> results types should never appear in GCC, or any other tool that
> shares the contrib/ directly, so this change should be harmless.
>
> In this patch series:
> https://sourceware.org/pipermail/gdb-patches/2020-April/167847.html
> changes were made in GDB's use of Dejagnu so that two additional
> conditions could be detected, these are:
>
> 1. Test names that contain either the build or source paths. Such
> test names make it difficult to compare the results of two test runs
> of GDB from two different directories, and
Yea, this is an annoyance and handling it better is definitely a good thing.
>
> 2. Duplicate test names. Duplicates make it difficult to track down
> exactly which test has failed.
They certainly do. The right thing to do here is (of course) to fix the test
name.
>
> When running Dejagnu on GDB we can now (sometimes) see two additional
> test result types matching the above conditions, these are '# of paths
> in test names' and '# of duplicate test names'.
>
> If the test is run in parallel mode (make -j...) then these extra test
> results will appear in the individual test summary files, but are not
> merged into the final summary file.
>
> Additionally, within the summary file there are now two new types of
> test summary line, these are 'PATH: ...' and 'DUPLICATE: ...', these
> allow users to quickly search the test summary to track down where the
> offending test names are. These lines are similarly not merged into
> the unified gdb.sum file after a parallel test run.
>
> This commit extends the dg-extract-results.* scripts to calculate the
> totals for the two new result types, and to copy the new test summary
> lines into the unified summary file.
>
> contrib/ChangeLog:
>
> * dg-extract-results.py: Handle GDB specific test types.
> * dg-extract-results.sh: Likewise.
OK
jeff
>
