On Tue, 6 Dec 2011, Han Shen wrote: > +gcc_gxx_include_dir_add_sysroot=0 > +if test "${with_sysroot+set}" = set; then : > + gcc_gxx_without_sysroot=`expr "${gcc_gxx_include_dir}" : > "${with_sysroot}"'\(.*\)'` > + if test "${gcc_gxx_without_sysroot}"; then :
No need for the " :" after "then" in two places here (the only reason I could see for having it would be if the contents of the "if" were the expansion of an autoconf macro that might expand to empty, so you needed to make sure the contents were nonempty). The patch is OK with that fixed. -- Joseph S. Myers jos...@codesourcery.com