On Wed, Apr 15, 2020 at 1:47 PM Thomas Koenig <tkoe...@netcologne.de> wrote:
>
> Hi Fritz,
>
> > While you're touching the code anyway, how would you feel about
> > replacing the nearby "goto done"s with a chain of "else if"? There's
> > really no reason I can see for goto here, since the block following
> > the conditions is already "done".
>
> I think this would really be pushing things at stage 4.  Theoretically,
> we are expected to do regression and documentation fixes only.
> Since Fortran is not release critical, we are welcome to break
> our compiler if we want to :-) but we should really try to
> restrict outselves at least a little. The little cleanup that I proposed
> is also borderline (but maybe a little less so), so I'd rather commit
> as I proposed.
>
> Any other comments?  If not, I'll commit in a couple of days.
[...]

Fair enough. No further comments, that patch looks good. Thanks!

---
Fritz

Reply via email to