Thank you for your suggestions. I have modified accordingly and a full test has been carried, no new failure witnessed. Attached please find the new patch which has been adjusted to be suitable for git am. Does the v2 patch look better ?
Thanks, Duan bo -----Original Message----- From: Wilco Dijkstra [mailto:wilco.dijks...@arm.com] Sent: Tuesday, April 14, 2020 4:40 AM To: GCC Patches <gcc-patches@gcc.gnu.org>; duanbo (C) <duan...@huawei.com> Subject: Re: [PATCH PR00002] aarch64：Add an error message in large code model for ilp32 Hi Duanbo, > This is a simple fix for pr94577. > The option -mabi=ilp32 should not be used in large code model. Like x86, > using -mx32 and -mcmodel=large together will result in an error message. > On aarch64, there is no error message for this option conflict. > A solution to this problem can be found in the attached patch. > Bootstrap and tested on aarch64 Linux platform. No new regression witnessed. > Any suggestion? Thanks for your patch, more than 4GB doesn't make any sense with ILP32 indeed. A few suggestions: It would be good to also update the documentation for -mcmodel=large to state it is incompatible with -fpic, -fPIC and -mabi=ilp32. The patch adds a another switch statement on mcmodel that ignores the previous processing done (which may changes the selected mcmodel). It would be safer and more concise to use one switch at the top level and in each case use an if statement to handle the special cases. A few minor nitpics: + PR target/94577 + * gcc.target/aarch64/pr94577.c : New test Just like comments, there should be a '.' at the end of changelog entries. AFAICT the format isn't exactly specified, but the email header should be like: [PATCH][AArch64] PR94577: Add an error message in large code model for ilp32 Sometimes the PR number is also placed in brackets. Cheers, Wilco
pr94577-v2.patch
Description: pr94577-v2.patch
