Hi Dennis, > -----Original Message----- > From: Dennis Zhang <dennis.zh...@arm.com> > Sent: 07 April 2020 13:31 > To: gcc-patches@gcc.gnu.org > Cc: nd <n...@arm.com>; Richard Earnshaw <richard.earns...@arm.com>; > Ramana Radhakrishnan <ramana.radhakrish...@arm.com>; Kyrylo > Tkachov <kyrylo.tkac...@arm.com> > Subject: Re: [PATCH][Arm][2/4] Custom Datapath Extension intrinsics: > instructions using FPU/MVE S/D registers > > Hi all, > > This patch is updated to support DImode for vfp target as required by CDE. > Changelog is updated as following. > > Is this ready for commit please?
This is ok. Has the first patch been updated and committed yet? Thanks, Kyrill > > Cheers > Dennis > > gcc/ChangeLog: > > 2020-04-07 Dennis Zhang <dennis.zh...@arm.com> > Matthew Malcomson <matthew.malcom...@arm.com> > > * config/arm/arm-builtins.c (CX_IMM_QUALIFIERS): New macro. > (CX_UNARY_QUALIFIERS, CX_BINARY_QUALIFIERS): Likewise. > (CX_TERNARY_QUALIFIERS): Likewise. > (ARM_BUILTIN_CDE_PATTERN_START): Likewise. > (ARM_BUILTIN_CDE_PATTERN_END): Likewise. > (arm_init_acle_builtins): Initialize CDE builtins. > (arm_expand_acle_builtin): Check CDE constant operands. > * config/arm/arm.h (ARM_CDE_CONST_COPROC): New macro to set the > range > of CDE constant operand. > * config/arm/arm.c (arm_hard_regno_mode_ok): Support DImode for > TARGET_VFP_BASE. > (ARM_VCDE_CONST_1, ARM_VCDE_CONST_2, ARM_VCDE_CONST_3): > Likewise. > * config/arm/arm_cde.h (__arm_vcx1_u32): New macro of ACLE interface. > (__arm_vcx1a_u32, __arm_vcx2_u32, __arm_vcx2a_u32): Likewise. > (__arm_vcx3_u32, __arm_vcx3a_u32, __arm_vcx1d_u64): Likewise. > (__arm_vcx1da_u64, __arm_vcx2d_u64, __arm_vcx2da_u64): Likewise. > (__arm_vcx3d_u64, __arm_vcx3da_u64): Likewise. > * config/arm/arm_cde_builtins.def: New file. > * config/arm/iterators.md (V_reg): New attribute of SI. > * config/arm/predicates.md (const_int_coproc_operand): New. > (const_int_vcde1_operand, const_int_vcde2_operand): New. > (const_int_vcde3_operand): New. > * config/arm/unspecs.md (UNSPEC_VCDE, UNSPEC_VCDEA): New. > * config/arm/vfp.md (arm_vcx1<mode>): New entry. > (arm_vcx1a<mode>, arm_vcx2<mode>, arm_vcx2a<mode>): Likewise. > (arm_vcx3<mode>, arm_vcx3a<mode>): Likewise. > > gcc/testsuite/ChangeLog: > > 2020-04-07 Dennis Zhang <dennis.zh...@arm.com> > > * gcc.target/arm/acle/cde_v_1.c: New test. > * gcc.target/arm/acle/cde_v_1_err.c: New test. > * gcc.target/arm/acle/cde_v_1_mve.c: New test. > > > Hi all, > > > > This patch is updated as attached. > > It's rebased to the top. Is it ready for commit please? > > > > Cheers > > Dennis > > > > > Hi all, > > > > > > This patch is part of a series that adds support for the ARMv8.m Custom > Datapath Extension (CDE). > > > It enables the ACLE intrinsics calling VCX1<A>, VCX2<A>, and VCX3<A> > instructions who work with FPU/MVE 32-bit/64-bit registers. > > > > > > This patch depends on the CDE feature patch: > https://gcc.gnu.org/pipermail/gcc-patches/2020-March/541921.html > > > It also depends on the MVE framework patch: > https://gcc.gnu.org/pipermail/gcc-patches/2020-February/540415.html > > > ISA has been announced at > https://developer.arm.com/architectures/instruction-sets/custom- > instructions > > > > > > Regtested and bootstrapped for arm-none-linux-gnueabi-armv8-m.main. > > > > > > Is it OK for commit please? > > > > > > Cheers > > > Dennis > > >