On 3/26/20 3:40 AM, Martin Liška wrote:
Hi.

I'm suggesting to provide a warning when one uses -flto=jobserver
but we can't detect job server for some reason.

Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

Ready to be installed in next stage1?
Thanks,
Martin

gcc/ChangeLog:

2020-03-26  Martin Liska  <mli...@suse.cz>

     PR driver/94330
     * lto-wrapper.c (run_gcc): When using -flto=jobserver,
     report warning when the jobserver is not detected.

Sounds like a useful warning.  It would be even better if it said why.
jobserver_active_p() returns false under one of at least three distinct
conditions.  If the function provided a status string in addition to
the boolean result, the string could be included in the text of
the warning.

As an aside, I'd expect -Wformat-diag to complain about the trailing
period:

+       warning (0, "jobserver is not available.");

Martin

Reply via email to