On Wed, 18 Mar 2020, Martin Liška wrote: > On 3/17/20 11:41 PM, Martin Sebor wrote: > > The script reports errors by emitting them as #error directives into > > standard output (so they cause the build to fail). Should this new > > routine do the same thing? (/dev/stderr is also not available on all > > flavors of UNIX but I'm not sure how much that matters here.) > > Good point Martin. Yes, #error emission works fine here: > > ./options.h:1:2: error: #error Empty option argument 'Enum' during parsing of: > Enum (diagnostic_prefixing_rule) String(once) > Value(DIAGNOSTICS_SHOW_PREFIX_ONCE) > 1 | #error Empty option argument 'Enum' during parsing of: Enum > (diagnostic_prefixing_rule) String(once) Value(DIAGNOSTICS_SHOW_PREFIX_ONCE) > | ^~~~~ > > There's updated version of the patch.
This version is also OK. -- Joseph S. Myers jos...@codesourcery.com
