On 3/16/20 9:48 AM, Rainer Orth wrote:
Hi Martin,
It's fix for Darwin target and similar others which do
not support the asembler directive.
Ready for master?
I'm usually all for using effective-target keywords instead of ad-hoc
tests or target lists, but this seems like a single-use case and thus a
bit too much. Maybe restrict to gas instead?
Yes, good idea!
Or is it possible to
change the test in a way that doesn't depend on special unportable
target assembler options? I haven't looked admittedly.
If none of this works out:
* Please change the keyword to as_execstack (assuming that an assembler
supports the positive form support the negative one, too). "wa"
doesn't tell me anything...
* This needs documenting in sourcebuild.texi, as always.
So, if there's really no other option: ok with those changes.
gcc/testsuite/ChangeLog:
2020-03-16 Martin Liska <mli...@suse.cz>
PR lto/94157
* gcc.dg/lto/pr94157_0.c: Add wa_noexecstack effective
target filter.
* lib/target-supports.exp: Add
check_effective_target_wa_noexecstack.
One question (because I noticed it in several of your patch submissions
lately): do you have a particularly short line length configure for
ChangeLogs or in general?
I use contrib/vimrc with line length limit 80 chars.
Many of the lines are way below a 75
character limit, which doesn't improve readablity...
Thanks for the notice. Do you really suffer from lines slighly
longer than 80 chars?
Martin
Rainer
>From 023c3b3e8c530b98fdc6bae91e2dc58aa2336c2f Mon Sep 17 00:00:00 2001
From: Martin Liska <mli...@suse.cz>
Date: Mon, 16 Mar 2020 09:24:44 +0100
Subject: [PATCH] Filter a test-case with gas.
gcc/testsuite/ChangeLog:
2020-03-16 Martin Liska <mli...@suse.cz>
PR lto/94157
* gcc.dg/lto/pr94157_0.c: Add gas effective
target filter.
---
gcc/testsuite/gcc.dg/lto/pr94157_0.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/testsuite/gcc.dg/lto/pr94157_0.c b/gcc/testsuite/gcc.dg/lto/pr94157_0.c
index 3bca677c4fb..a6e308b855b 100644
--- a/gcc/testsuite/gcc.dg/lto/pr94157_0.c
+++ b/gcc/testsuite/gcc.dg/lto/pr94157_0.c
@@ -1,4 +1,5 @@
/* { dg-lto-do link } */
+/* { dg-require-effective-target gas } */
/* { dg-lto-options { { -O0 -fipa-vrp -flto -Wa,--noexecstack -Wa,--noexecstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack -Wa,--execstack } } } */
int main() {
--
2.25.1
