Hi, 

On Fri, 28 Feb 2020, Alexey Neyman wrote:
> On 2/26/20 11:40 AM, Richard Biener wrote:
> 
> Attached is a revised patch that enables DIE generation for external variables
> at -g1 without an additional option.

I can't substantially review the patch, but there's a couple of nits that
will need fixing anyway:

This file seems to be missing from the patch:

        * gcc/testsuite/gcc.dg/debug/dwarf2/pr93751-3: New test.

Also please note that GCC coding style requires a space before a paren:

    TREE_PUBLIC (decl)

Thanks.
Alexander

Reply via email to