On Sun, Jan 19, 2020 at 12:54:51PM +0100, Jan Hubicka wrote:
> > Bootstrapped/regtested on x86_64-linux and aarch64-linux.
> >
> > Feng
> > ---
> > 2020-01-19 Feng Xue <f...@os.amperecomputing.com>
> >
> > PR ipa/93166
> > * ipa-cp.c (get_info_about_necessary_edges): Remove value
> > check assertion.
>
> OK.
> Please next time write short description on the problem in email so one
> does not need to look up the PR log.
The test FAILs with -std=c++98 (because it really requires C++11), but more
importantly, it doesn't actually test what it is supposed to test, i.e.
doesn't FAIL before the ipa-cp.c change and succeed with it.
That is because it is a dg-do compile test, it needs to be a proper LTO test
for this.
Fixed thusly, tested on x86_64-linux and i686-linux (with Thursday snapshot
where it FAILs and current where it PASSes), committed to trunk as obvious.
2020-01-26 Jakub Jelinek <ja...@redhat.com>
PR ipa/93166
* g++.dg/pr93166.C: Move to ...
* g++.dg/pr93166_0.C: ... here. Turn it into a proper lto test.
diff --git a/gcc/testsuite/g++.dg/pr93166.C
b/gcc/testsuite/g++.dg/lto/pr93166_0.C
similarity index 95%
rename from gcc/testsuite/g++.dg/pr93166.C
rename to gcc/testsuite/g++.dg/lto/pr93166_0.C
index e9234ce7a0c..52f7ddf4016 100644
--- a/gcc/testsuite/g++.dg/pr93166.C
+++ b/gcc/testsuite/g++.dg/lto/pr93166_0.C
@@ -1,5 +1,10 @@
-// { dg-do compile }
-// { dg-options "-shared -flto -O2 -fPIC -fvisibility=hidden" }
+// PR ipa/93166
+// { dg-lto-do link }
+// { dg-lto-options { { -fPIC -O2 -flto -fvisibility=hidden } } }
+// { dg-require-effective-target shared }
+// { dg-require-effective-target fpic }
+// { dg-extra-ld-options "-shared" }
+// { dg-require-visibility "" }
namespace Qt {
enum DropAction {};
Jakub
