On 1/6/20 8:03 PM, Jan Hubicka wrote:
OK
Actually I am not so sure about this patch - how do we ensure
reproducibility in this case?
ISTM that anyone trying to have reproducible builds shouldn't be using
PGO based optimizations.
OpenSUSE does that. Builds are supposed to be reproducible + PGO is used
for number of core packages (like GCC itself). This was motivation of
original Martin's change to drop TOPN values from profile more
agressively.
I agree with Honza that we should provide as reproducible builds as possible.
On the other hand, we should not be rigid and allow a reasonable sample loss.
That's why I added a parameter that be tweaked at openSUSE side.
Note that original motivation for the patch was your PR :) So that I'm surprised
I don't like the patch much.
Martin
Honza
jeff
