On Wed, 2019-12-18 at 16:30 +0100, Georg-Johann Lay wrote: > Hi, this patch turns off -fipa-icf-variables because it generates wrong > code like for PR92606. As there is no target hook that could decide > whether such optimizations are obsolete, disable such optimizations > alltogether until PR92932 (target hook to disable such optimizations > depending on object attributes and address-spcace) is available. > > Ok to apply? > > Johann > > > Work around PR ipa/92932 by disabling -fipa-icf-variables until > PR92932 will have been solved. > > PR ipa/92932 > PR target/92606 > * common/config/avr/avr-common.c (avr_option_optimization_table) > <-fipa-icf-variables>: Disable. This seems backwards to me. Instead of disabling the optimization in the target files we should prevent the optimization from firing in cases where it can't reasonably work.
Jeff
