On Mon, Dec 16, 2019 at 1:25 AM Olivier Hainque <hain...@adacore.com> wrote:
>
> Hello,
>
> Some tests from  gcc/testsuite/gcc.target/aarch64/aapcs64
> resort to the abitest.S source, which defines a few weak symbols:
>
>   ...
>   .weak   testfunc
>   .weak   testfunc_ptr
>   .weak   saved_return_address
>
> The attached patch is a proposal to prevent the execution of
> those tests in configurations where weak symbols are advertised
> as not supported.
>
> This cures a significant number of failures on VxWorks and bootstrap
> + regress tests fine on aarch64-linux.
>
> Is this ok to commit ?

Why does VxWorks not have weak symbol support when it is an elf
target?  I can understand it not having support in a loader but these
symbols should all be resolved at build time.

Thanks,
Andrew Pinski

>
> Thanks in advance!
>
> With Kind Regards,
>
> Olivier
>
> 2019-12-16  Joel Brobecker  <brobec...@adacore.com>
>             Olivier Hainque  <hain...@adacore.com>
>
>         testsuite/
>
>         * gcc.target/aarch64/aapcs64/aapcs64.exp: Guard tests using
>         abitest.S by check_weak_available.
>

Reply via email to