On Wed, Dec 11, 2019 at 06:18:31PM +0800, Hongtao Liu wrote: > Hi: > This patch is about to add tune option for integer mask cmov, for > some targets has both integer mask register and sse mask register, > this tune indicates to use integer one. Currently it's default on for > m_CORE_AVX512. > > Bootstrap is ok, regression test on i386/x86_64 backends is ok. > ok for trunk?
I don't see the need for that right now, doesn't m_CORE_AVX512 include all CPUs that support AVX512VL right now? If yes, the whole effect of the patch will be that the masked registers won't be used in generic tuning, something most people actually use. I think it is worth adding something like this only when some other AVX512VL capable CPUs appear and what will perform better on those. Jakub