Hi Matthias,
> On 06.12.19 12:28, Rainer Orth wrote:
>> I Ian,
>>
>>> This libgo patch arranges for go-context.S to always be marked as
>>> using a non-executable stack. This is not required for all targets,
>>> but should do little harm. Bootstrapped on x86_64-pc-linux-gnu.
>>> Committed to mainline.
>>
>> unfortunately, it does, breaking bootstrap on Solaris/SPARC and x86 with
>> the native assembler:
>>
>> * Solaris/SPARC with as:
>>
>> /usr/ccs/bin/as: "/var/tmp//ccSl12Nb.s", line 7: error: invalid character
>> (0x40)
>> /usr/ccs/bin/as: "/var/tmp//ccSl12Nb.s", line 7: error: quoted-string
>> operand required
>> /usr/ccs/bin/as: "/var/tmp//ccSl12Nb.s", line 7: error: statement syntax
>> make[4]: *** [Makefile:1433: runtime/go-context.lo] Error 1
>>
>> * Solaris/x86 with as:
>>
>> Assembler:
>> "/vol/gcc/src/hg/trunk/local/libgo/runtime/go-context.S", line 74
>> : Syntax error
>> Near line: " .section .note.GNU-stack,"",@progbits"
>> make[4]: *** [Makefile:1433: runtime/go-context.lo] Error 1
>
> also on arm-linux-gnueabi*. Patch in PR go/92820
that won't help: for one, those .note.GNU-stack sections are useless on
Solaris. Even if this weren't the case, the syntax is still wrong:
Solaris/SPARC as needs
.section ".note.GNU-stack",,#progbits
while Solaris/x86 as doesn't allow for '-' in section names (and there's
no quoting mechanism IIRC).
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
