Hi Joseph, > On Mon, 25 Nov 2019, Rainer Orth wrote: > >> it seems you missed updating a couple of testcases that are ia32-only: > > I think it's unavoidable that such target-specific testcases need updating > by someone testing on the target in question.
like so? Tested on i386-pc-solaris2.11. Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Center for Biotechnology, Bielefeld University 2019-11-26 Rainer Orth <r...@cebitec.uni-bielefeld.de> * g++.dg/cpp0x/gen-attrs-36.C: Update expected diagnostics. * g++.dg/cpp0x/gen-attrs-37.C: Likewise. * g++.dg/cpp0x/gen-attrs-8.C: Likewise.
# HG changeset patch # Parent f266edd7bbd4f5485b25b37a46b4a89bc83eecec Fix ia32 testsuite failures from C2x attributes on types diff --git a/gcc/testsuite/g++.dg/cpp0x/gen-attrs-36.C b/gcc/testsuite/g++.dg/cpp0x/gen-attrs-36.C --- a/gcc/testsuite/g++.dg/cpp0x/gen-attrs-36.C +++ b/gcc/testsuite/g++.dg/cpp0x/gen-attrs-36.C @@ -9,16 +9,16 @@ class T; class L { }; class P : public L { - typedef void (T::* [[gnu::__stdcall__]] F2) (L*); // { dg-warning "ignored" } - typedef void (T::*F) (L*) [[gnu::__stdcall__]]; // { dg-warning "ignored" } + typedef void (T::* [[gnu::__stdcall__]] F2) (L*); // { dg-warning "only applies to function types" } + typedef void (T::*F) (L*) [[gnu::__stdcall__]]; void f(bool aAdd); }; class T { public: - virtual void A(L *listener) [[gnu::__stdcall__]] = 0; // { dg-warning "ignored" } - virtual void R(L *listener) [[gnu::__stdcall__]] = 0; // { dg-warning "ignored" } + virtual void A(L *listener) [[gnu::__stdcall__]] = 0; + virtual void R(L *listener) [[gnu::__stdcall__]] = 0; }; void P::f(bool aAdd) { diff --git a/gcc/testsuite/g++.dg/cpp0x/gen-attrs-37.C b/gcc/testsuite/g++.dg/cpp0x/gen-attrs-37.C --- a/gcc/testsuite/g++.dg/cpp0x/gen-attrs-37.C +++ b/gcc/testsuite/g++.dg/cpp0x/gen-attrs-37.C @@ -10,7 +10,7 @@ struct S { S(const S &s) {} }; -S getS() [[gnu::__stdcall__]]; // { dg-warning "ignored" } +S getS() [[gnu::__stdcall__]]; void test() { diff --git a/gcc/testsuite/g++.dg/cpp0x/gen-attrs-8.C b/gcc/testsuite/g++.dg/cpp0x/gen-attrs-8.C --- a/gcc/testsuite/g++.dg/cpp0x/gen-attrs-8.C +++ b/gcc/testsuite/g++.dg/cpp0x/gen-attrs-8.C @@ -3,5 +3,5 @@ // { dg-require-effective-target c++11 } extern int * ([[gnu::stdcall]] *fooPtr)( void); // { dg-error "expected" } -int * [[gnu::stdcall]] myFn01( void) { return 0; }// { dg-warning "ignored" } +int * [[gnu::stdcall]] myFn01( void) { return 0; }// { dg-warning "only applies to function types" }