On 11/23/19 2:12 PM, Jan Hubicka wrote:
I always use the outer function params since that is how local parameters behave. I hope it is kind of what is also expected in most case: it is better to inline agressively into -O3 compiled code rather than inline agressively -O3 functions into their callers.
Hello. Great that you converted the inliner parameters so quickly!
New params infrastructure is nice. One drawback is that is very hard to search for individual param uses since they all occupy global namespace. With C++ world we had chance to do something like params.param_flag_name or params::param_flag_name instead...
Why is it difficult to search for all usages? Now, we don't use any PARAM_XYZ macros and one can easily find all usages with something like: $ git grep param_stack_frame_growth Martin
