On Wed, Nov 20, 2019 at 5:46 PM Tobias Burnus <tobias_bur...@mentor.com> wrote: > > Hi Janne, > > On 11/18/19 9:34 PM, Janne Blomqvist wrote: > > Now that we require a minimum of MPFR 3.1.0+ to build GCC, we can do > > some modernization of the MPFR usage in the GFortran frontend. > > OK – thanks for the cleanup. > > [For reference, those changes were introduced in MPFR 3.0.0, cf. > https://www.mpfr.org/mpfr-3.0.0/#changes ; 3.0 and 3.1 also added a > bunch of new functions, MPFR_RNDA and did remove some undefined behaviour.] > > Do you intent update the other places as well? Namely: > > > This patch replaces > > 1) GMP_RND* with MPFR_RND* > Also used by: configure.ac, gcc/builtins.c, gcc/fold-const-call.c, > gcc/gimple-ssa-sprintf.c, gcc/go/…, gcc/real.c, gcc/realmpfr.h, > gcc/ubsan.c. > > 2) mp_exp_t with mpfr_exp_t > > gcc/realmpfr.c + gcc/go/… > > > 3) mp_prec_t with mpfr_prec_t > (only used by gcc/fortran) > > 4) mp_rnd_t with mpfr_rnd_t > > gcc/builtins.c, gcc/fold-const-call.c, gcc/realmpfr.c >
Thanks for the review, committed as r278523. My plan was that once the fortran-specific parts are done, I'll reassign the PR to the middle-end, and then me or somebody else can make a separate patch for that. However, since we're in stage3 now I believe this will have to wait until after the GCC 10 release as the middle-end people seem to take these rules more seriously. -- Janne Blomqvist
