On 11/18/19 7:04 PM, Marek Polacek wrote:
The newly added diagnostic causes an ICE because the new grokdeclarator call returned error_mark_node and DECL_SOURCE_LOCATION crashes on that. So don't attempt to print the new diagnostic if we've encountered something not resembling a bit-field.Bootstrapped/regtested on x86_64-linux, ok for trunk? 2019-11-18 Marek Polacek <pola...@redhat.com> PR c++/92450 - ICE with invalid nested name specifier. * parser.c (cp_parser_member_declaration): Bail out for invalid code. * g++.dg/parse/crash71.C: New test. diff --git gcc/cp/parser.c gcc/cp/parser.c index c473e7fd92f..caed6946977 100644 --- gcc/cp/parser.c +++ gcc/cp/parser.c @@ -25052,6 +25052,9 @@ cp_parser_member_declaration (cp_parser* parser) tree d = grokdeclarator (declarator, &decl_specifiers, BITFIELD, /*initialized=*/false, &attributes); + /* Hopelessly invalid code, give up. */ + if (error_operand_p (d)) + goto out; error_at (DECL_SOURCE_LOCATION (d), "bit-field %qD has non-integral type %qT", d, TREE_TYPE (d));
Don't we still want the rest of the error-recovery code there, i.e. skipping to the end of the statement?
Jason
