On 11/13/19 4:25 PM, Sandra Loosemore wrote:
On 11/13/19 6:45 AM, Martin Liška wrote:
Hi.

The patch is about a documentation entry for a newly added
option in GCC 10.

Ready for trunk?

I thought this would be OK, until I saw:

+Enabled by default.

At the beginning of invoke.texi where it is talking about options having both -foo 
and -fno-foo forms, it says "This manual documents
only one of these two forms, whichever one is not the default."  So I think you 
should be documenting -fno-allocation-dce here instead of the positive form.

Thank you for the review.
I've changed that and I'm going to install the patch.

Martin


-Sandra

>From e1ebd30612d688fb03024a48e38f228d273545c4 Mon Sep 17 00:00:00 2001
From: Martin Liska <mli...@suse.cz>
Date: Wed, 13 Nov 2019 14:44:41 +0100
Subject: [PATCH] Document -fallocation-dce.

gcc/ChangeLog:

2019-11-13  Martin Liska  <mli...@suse.cz>

	PR other/92329
	* doc/invoke.texi: Document -fallocation-dce.
---
 gcc/doc/invoke.texi | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 00eb7e77808..10f144ccc39 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -407,7 +407,7 @@ Objective-C and Objective-C++ Dialects}.
 -falign-jumps[=@var{n}[:@var{m}:[@var{n2}[:@var{m2}]]]] @gol
 -falign-labels[=@var{n}[:@var{m}:[@var{n2}[:@var{m2}]]]] @gol
 -falign-loops[=@var{n}[:@var{m}:[@var{n2}[:@var{m2}]]]] @gol
--fallow-store-data-races @gol
+-fno-allocation-dce -fallow-store-data-races @gol
 -fassociative-math  -fauto-profile  -fauto-profile[=@var{path}] @gol
 -fauto-inc-dec  -fbranch-probabilities @gol
 -fcaller-saves @gol
@@ -10267,6 +10267,10 @@ The maximum allowed @var{n} option value is 65536.
 
 Enabled at levels @option{-O2}, @option{-O3}.
 
+@item -fno-allocation-dce
+@opindex fno-allocation-dce
+Do not remove unused C++ allocations in dead code elimination.
+
 @item -fallow-store-data-races
 @opindex fallow-store-data-races
 Allow the compiler to introduce new data races on stores.
-- 
2.24.0

Reply via email to