On Thu, 7 Nov 2019, Egeyar Bagcioglu wrote:
> On 11/7/19 8:47 AM, Segher Boessenkool wrote:
> > On Wed, Nov 06, 2019 at 06:21:33PM +0100, Egeyar Bagcioglu wrote:
> > > +proc dg-require-target-object-format { args } {
> > > +    if { [gcc_target_object_format] == [lindex $args 1] } {
> > > + return
> > > +    }
> > "==" for strings is dangerous.  Use "eq" or "string equal"?
>
> I see many "string match"es. I will make the change.

Please instead use "string equal".

Code in target-supports-dg.exp is not a trustworthy reference.
I suggest RTFM <http://www.tcl.tk/>, where you can see that
"string match" does a glob compare.

brgds, H-P

Reply via email to