Thanks for implementing this.
Jakub Jelinek <ja...@redhat.com> writes:
> On Wed, Oct 30, 2019 at 02:12:30PM +0000, Szabolcs Nagy wrote:
>> On 29/10/2019 17:15, Jakub Jelinek wrote:
>> > +void f03 (void);
>> > +#pragma omp declare variant (f03) match
>> > (device={kind(any),arch(x86_64),isa(avx512f,avx512bw)})
>> > +void f04 (void);
>>
>> 1) it's not clear from the omp spec what is the intended
>> syntax for isa-name, arch-name and extension-name, but
>> i expected strings in "".
>
> Yes, it is indeed not clear, subject to ongoing discussions.
> My reading of the spec was that all the *-name-list are comma
> separated lists of identifiers, some others in the committee
> want now (yesterday's discussions) string literals instead
> when I and others pointed out that isa(core-avx512) can't be valid,
> but strangely only for isa/arch/extension but not e.g. for
> kind or vendor which would still take identifier lists etc.
Might be completely wrong, but wouldn't the identifiers be subject to
macro expansion? That would make it harder to use the pragmas safely
in system headers.
Richard
