On Wed, Oct 23, 2019 at 11:45 PM Prathamesh Kulkarni <prathamesh.kulka...@linaro.org> wrote: > > Hi, > The attached patch tries to fix PR92163 by calling > gimple_purge_dead_eh_edges from ifcvt_local_dce if we need eh cleanup. > Does it look OK ?
Hmm. I think it shows an issue with the return value of remove_stmt_form_eh_lp which is true if the LP index is -1 (externally throwing). We don't need to purge any edges in that case. That is, if-conversion should never need to do EH purging since that would be wrong-code. As of the segfault can you please instead either pass down need_eh_cleanup as function parameter (and NULL from ifcvt) or use the return value in DSE to set the bit in the caller. Thanks, Richard. > Thanks, > Prathamesh