On Thu, Oct 17, 2019 at 10:37:33AM +0100, Iain Sandoe wrote: > Segher Boessenkool <seg...@kernel.crashing.org> wrote: > > > Okay for trunk. For backports maybe wait a bit longer than usual? So ask > > again in two weeks, maybe? I know it's important for the darwin port, but > > the generic part is a little scary. > > No problem (I would like to get this in to the final issue of 7, if possible). > > FWIW, this implementation is completely guarded on TARGET_MACHO.
Yeah, I misread that, somehow I thought the big change was inside mem_operand_gpr. It isn't, and it is perfectly safe elsewhere, so no special care is needed here at all, for backports. > >> --- a/gcc/config/rs6000/rs6000.md > >> +++ b/gcc/config/rs6000/rs6000.md > >> @@ -6894,13 +6894,6 @@ > >> ;; do the load 16-bits at a time. We could do this by loading from memory, > >> ;; and this is even supposed to be faster, but it is simpler not to get > >> ;; integers in the TOC. > >> -(define_insn "movsi_low" > > > > Should the preceding comment be moved elsewhere / changed / deleted? > > It seemed to be a comment about the following code - or something that should > have been deleted long ago - it mentions the TOC, which Darwin does not use > so not a Darwin-related thing. > > Happy to do a separate patch to delete it that’s desired. I think the comment is more confusing than helpful, currently. So sure, removing it is pre-approved. Segher
